Repository navigation
Build the polytopelabs image against node-core from polytope-labs/subql - #2
Merged
Merged
Conversation
Adds a workflow that packs @subql/node-core from a polytope-labs/subql ref (default main), points @subql/node-ethereum at that tarball instead of npm, and publishes polytopelabs/subql-node-ethereum from a Dockerfile that installs the same tarball. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage reportCaution Test run failed
Test suite run failedFailed tests: 34/109. Failed suites: 8/16.Report generated by 🧪jest coverage report action from 4415c24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EVM indexers need the node-core fixes made in polytope-labs/subql, such as the multichain rewind lock liveness fix in polytope-labs#3, before those fixes are released on npm. This builds
polytopelabs/subql-node-ethereumagainst node-core from the fork instead of the npm package.scripts/use-polytope-node-core.sh <subql checkout>builds and packs@subql/node-corefrom a polytope-labs/subql checkout intovendor/subql-node-core.tgz, then points@subql/node-ethereumat that tarball. node-core's other@subql/*dependencies still resolve from npm, because the fork only changes node-core and the substrate node.packages/node/polytope/Dockerfileis the upstream Dockerfile, except it installs node-core from the tarball. The upstream Dockerfile is unchanged so upstream syncs stay clean..github/workflows/polytopelabs-docker.ymlruns on manual dispatch (inputssubqlRef, defaultmain, andisLatest) or when anode-ethereum/v*tag is pushed. It pushesv<version>andv<version>-<subql commit>, pluslatestwhen requested. The commit tag pins the exact node-core build.Tested by building the image locally for amd64 against the PR subquery#3 branch. The image contains exactly one
@subql/node-core, version 19.3.4-0 with the rewind fix, and--versionprints 6.5.0. The workflow itself has not been run yet.Node-core fixes only reach the image once they are on the ref being built:
mainby default, which PR subquery#3 has not been merged into yet.🤖 Generated with Claude Code