Repository navigation
[simplex]: show the funding shortfall only before fills are enabled - #1402
Merged
Merged
Conversation
ChainFunding.funded and delegated are independent: the paymaster draws the fee token down as it fills, so a delegated chain routinely sits under the recommended balance. The dashboard Chains page treated that as an actionable shortfall, showing "Fills enabled" in warning yellow next to a "Check again" link that could change nothing. The warning and link now show only while the chain is not yet delegated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the dashboard Chains page, Ethereum and Polygon showed "Fills enabled" in warning yellow next to a "Check again" link — while Base and BNB Chain, also enabled, did not.
ChainFunding.fundedandChainFunding.delegatedare independent reads: once delegated, the paymaster draws the fee token down as it fills, so an actively filling chain routinely sits under the recommended 5. The page treated that as an actionable shortfall:fillsStatusreturned "Fills enabled" fromdelegated, while!fundedadded the yellow styling and the link — which could change nothing, since enabling fills was what the balance was for.The shortfall warning ("Needs at least 5 USDC…", yellow, "Check again") now shows only while a running chain is not yet delegated. A delegated chain reads "Fills enabled" in the normal muted style whatever its balance.
Validation
tsc --noEmiton the UI project: clean.