Windows and handles: refuse controllable windows; noopener OAuth popup - #158
Merged
Conversation
…r OAuth popup A parent or opener holding a WindowProxy to the visor tab can navigate it cross-origin. The visor now refuses to boot when framed or when window.opener is non-null, painting a framework-voice notice and a button that reopens the page with noopener. The opener test is one-sided (a hostile opener can disown its popup before navigating it here), so this catches the naive case only; COOP same-origin is recorded as the general form and as an optional deployment enhancement, never a requirement. Our own OAuth popup opens with noopener. With no handle on either side the returning page reports code-or-declined over a same-origin BroadcastChannel keyed by the ceremony's state; closed-detection is a ten-minute bound. No kernel change. New e2e scenario handled-window-refuses-to-boot; 17/17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parent or opener holding a WindowProxy to the visor tab can navigate it
cross-origin. The visor now refuses to boot when framed or when
window.opener is non-null, painting a framework-voice notice and a button
that reopens the page with noopener. The opener test is one-sided (a
hostile opener can disown its popup before navigating it here), so this
catches the naive case only; COOP same-origin is recorded as the general
form and as an optional deployment enhancement, never a requirement.
Our own OAuth popup opens with noopener. With no handle on either side the
returning page reports code-or-declined over a same-origin BroadcastChannel
keyed by the ceremony's state; closed-detection is a ten-minute bound.
No kernel change. New e2e scenario handled-window-refuses-to-boot; 17/17.
Automerge armed.