Adds Docker build check to PR workflow. Closes #5033#7230
Open
officialasishkumar wants to merge 1 commit into
Open
Adds Docker build check to PR workflow. Closes #5033#7230officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Contributor
|
@officialasishkumar can you please comment on the issue first before working on it? |
Contributor
Author
|
Commented on #5033 now for tracking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CI reliability for the CLI’s Docker distribution by ensuring the repository Dockerfile is built as part of the PR checks, catching Docker build regressions before release.
Changes:
- Adds a
docker_buildjob to.github/workflows/check_pr.ymlto build the Docker image on PRs. - Fixes a Dockerfile line-continuation issue (a trailing space after
\) that would break theRUN ... && ...chain duringdocker build.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Dockerfile | Fixes a broken line continuation so Docker builds succeed reliably. |
| .github/workflows/check_pr.yml | Adds a PR workflow job that runs a Docker Buildx build (no push) to validate the Dockerfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5033
Summary
Validation