Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2823 (Pie) and #2841 (Sunburst), part of #2754.
Marimekko renders through
SvgWrapperlike the other SVG charts, andSvgWrapperalready forwardsaria-label/aria-labelledby/aria-describedbyto the root<svg>. Marimekko just wasn't passing them through, so there was no way to give the chart an accessible name.This wires the same three optional props from
MarimekkotoSvgWrapper, matching Pie and Sunburst.packages/marimekko/src/types.ts: add the three optional props toMarimekkoCommonPropspackages/marimekko/src/Marimekko.tsx: forward them toSvgWrapperpackages/marimekko/tests/Marimekko.test.tsx: assert they reach the root<svg>, same shape as the Pie/Sunburst accessibility tests