Skip to content

Fixed: MPL 2 license detection fails when license contains a copyright header #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshmgross wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −2
Open

Fixed: MPL 2 license detection fails when license contains a copyright header #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/license_finder/license/definitions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def mpl2

matcher = AnyMatcher.new(
Matcher.from_template(Template.named('MPL2')),
HeaderMatcher.new(Matcher.from_regex(header_regexp))
HeaderMatcher.new(Matcher.from_regex(header_regexp), 3)
)

License.new(
Expand Down
14 changes: 13 additions & 1 deletion spec/lib/license_finder/license/definitions_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,21 @@
expect(subject).to be_matches_text 'Mozilla Public License, version 2.0'
expect(subject).to be_matches_text 'Mozilla Public Licence version 2.0'

expect(subject).not_to be_matches_text "Something else\nMozilla Public License, version 2.0"
expect(subject).not_to be_matches_text 'Mozilla Public License version 1.1'
end

it 'should return true if the text has a copyright header before the license' do
license_text_with_copyright = <<~TEXT
Copyright (c) 2026 My Company, Inc.

Mozilla Public License, version 2.0
TEXT
expect(subject).to be_matches_text license_text_with_copyright
end

it 'should return true if the license text appears within the first few lines' do
expect(subject).to be_matches_text "Something else\nMozilla Public License, version 2.0"
end
end
end

Expand Down