Add -buildvcs=false to the go list command#1048
Open
emmahsax wants to merge 2 commits into
Open
Conversation
Author
|
I'm not sure why the concourse-ci tests aren't running... it seems like maybe this repository has been disconnected from concourse-ci lately. However, it also seems like maybe this repository is like half-archived and won't be updated any more at all, since nobody's really touched it since May 2024. |
emmahsax
commented
Sep 12, 2025
| # Versioning | ||
| ENV PIP3_INSTALL_VERSION 20.0.2 | ||
| ENV GO_LANG_VERSION 1.17.13 | ||
| ENV GO_LANG_VERSION 1.18.10 |
Author
There was a problem hiding this comment.
This was my attempt to try to fix the concourse-ci tests, which may have been failing due to older versions of Go not supporting the buildvcs flag. Unfortunately, I'm not able to verify if this helps or not due to the concourse-ci tests no longer running on this PR.
emmahsax
force-pushed
the
add_buildvcs_false
branch
from
947bd8a to
5f20a7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve the issues seen in #1047, and has been tested with Go version 1.22.1.