Add steady-state decode benchmark#143
Draft
nishantmehta wants to merge 2 commits into
Draft
Conversation
BenchmarkDecode is skipped unless -oggfile is given and rebuilds the decoder and re-parses the stream every iteration, so it cannot track per-frame decode cost by default. Add BenchmarkDecodeSteady, which runs on the embedded tiny.ogg: it parses the packets once, reuses a single decoder and output buffer, warms up scratch, then loops the same packets. This isolates the recurring per-frame work (currently 0 allocs/op) from one-time setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
BenchmarkDecodeSteady, a benchmark for the steady-state, per-frame decode cost.Why
The existing
BenchmarkDecodeis skipped unless-oggfileis supplied (loadTestOggcalls
t.Skipwhen the flag is empty), and when it does run it constructs a new decoderand re-parses the ogg stream on every iteration. As a result there is no default-running
benchmark that tracks the recurring per-frame decode cost.
BenchmarkDecodeSteadyruns on the embeddedtestdata/tiny.ogg: it parses the packetsonce, reuses a single decoder and output buffer, warms up the decoder's scratch buffers,
and then loops the same packets. This isolates per-frame work from one-time setup.
Result
It documents and guards the allocation-free steady-state decode path. No production code
changes;
go test ./...passes.