Validate token storage keys before Redis reads/deletes - #451
Open
quentinmayo wants to merge 2 commits into
Open
Conversation
Reject tokens that do not match SnapPass key format so arbitrary Redis keys cannot be probed, read, or deleted via password retrieval endpoints.
xia0pin9
approved these changes
May 19, 2026
The throwaway `_` shadowed the gettext `_` imported from flask_babel, which flake8 flags as F811 and failed the lint (build 3.10) job. Restore the original descriptive `decryption_key` name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exists/get/deleteoperationREDIS_PREFIX+ 32 hex chars)session:42) cannot be used as an existence oracle or read/delete targetTest plan
MOCK_REDIS=1 .venv/bin/pytest -q tests.pyMOCK_REDIS=1 .venv/bin/pytest -q tests.py -k "non_snappass or rejects_non_snappass or get_password or password_exists or retrieve_password_api_v2 or check_password_api_v2"