Detect analyser fixtures missing a sufficient // lint >= comment for the version-specific PHP syntax they use

build/PHPStan/Build/RequiredPhpVersionVisitor.php

@@ -0,0 +1,158 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Build;
+
+use Override;
+use PhpParser\Modifiers;
+use PhpParser\Node;
+use PhpParser\NodeVisitorAbstract;
+use function in_array;
+use function strtolower;
+
+/**
+ * Detects the minimum PHP version a file requires to be parsed, based on the
+ * syntactic features it uses. Used to verify that analyser test fixtures carry
+ * a matching `// lint >= X.Y` comment so they get skipped on older PHP versions
+ * in CI instead of producing a hard parse error.
+ */
+final class RequiredPhpVersionVisitor extends NodeVisitorAbstract
+{
+
+	private const PHP_8_1 = 80100;
+	private const PHP_8_2 = 80200;
+	private const PHP_8_3 = 80300;
+	private const PHP_8_4 = 80400;
+	private const PHP_8_5 = 80500;
+
+	private ?int $requiredVersionId = null;
+
+	private ?string $reason = null;
+
+	public function getRequiredVersionId(): ?int
+	{
+		return $this->requiredVersionId;
+	}
+
+	public function getReason(): ?string
+	{
+		return $this->reason;
+	}
+
+	#[Override]
+	public function enterNode(Node $node): ?Node
+	{
+		if ($node instanceof Node\Stmt\Enum_) {
+			$this->require(self::PHP_8_1, 'enums');
+		}
+
+		if ($node instanceof Node\Expr\BinaryOp\Pipe) {
+			$this->require(self::PHP_8_5, 'the pipe operator');
+		}
+
+		if ($node instanceof Node\PropertyHook) {
+			$this->require(self::PHP_8_4, 'property hooks');
+		}
+
+		if ($node instanceof Node\IntersectionType) {
+			$this->require(self::PHP_8_1, 'pure intersection types');
+		}
+
+		if ($node instanceof Node\UnionType) {
+			foreach ($node->types as $innerType) {
+				if ($innerType instanceof Node\IntersectionType) {
+					$this->require(self::PHP_8_2, 'disjunctive normal form types');
+				}
+				if (!($innerType instanceof Node\Identifier) || strtolower($innerType->name) !== 'true') {
+					continue;
+				}
+
+				$this->require(self::PHP_8_2, 'the standalone "true" type');
+			}
+		}
+
+		if ($node instanceof Node\Stmt\Class_ && ($node->flags & Modifiers::READONLY) !== 0) {
+			$this->require(self::PHP_8_2, 'readonly classes');
+		}
+
+		if ($node instanceof Node\Stmt\Property && ($node->flags & Modifiers::READONLY) !== 0) {
+			$this->require(self::PHP_8_1, 'readonly properties');
+		}
+
+		if ($node instanceof Node\Param && ($node->flags & Modifiers::READONLY) !== 0) {
+			$this->require(self::PHP_8_1, 'readonly promoted properties');
+		}
+
+		if (
+			($node instanceof Node\Param || $node instanceof Node\Stmt\Property)
+			&& ($node->flags & Modifiers::VISIBILITY_SET_MASK) !== 0
+		) {
+			$this->require(self::PHP_8_4, 'asymmetric visibility');
+		}
+
+		if ($node instanceof Node\Stmt\ClassConst && $node->type !== null) {
+			$this->require(self::PHP_8_3, 'typed class constants');
+		}
+
+		if ($node instanceof Node\Expr\ClassConstFetch && $node->name instanceof Node\Expr) {
+			$this->require(self::PHP_8_3, 'dynamic class constant fetch');
+		}
+
+		if (
+			$node instanceof Node\Expr\FuncCall
+			|| $node instanceof Node\Expr\MethodCall
+			|| $node instanceof Node\Expr\NullsafeMethodCall
+			|| $node instanceof Node\Expr\StaticCall
+		) {
+			foreach ($node->args as $arg) {
+				if ($arg instanceof Node\VariadicPlaceholder) {
+					$this->require(self::PHP_8_1, 'first-class callable syntax');
+					break;
+				}
+			}
+		}
+
+		$this->checkStandaloneType($node);
+
+		return null;
+	}
+
+	private function checkStandaloneType(Node $node): void
+	{
+		$type = null;
+		if (
+			$node instanceof Node\Param
+			|| $node instanceof Node\Stmt\Property
+			|| $node instanceof Node\Stmt\ClassConst
+		) {
+			$type = $node->type;
+		} elseif (
+			$node instanceof Node\Stmt\Function_
+			|| $node instanceof Node\Stmt\ClassMethod
+			|| $node instanceof Node\Expr\Closure
+			|| $node instanceof Node\Expr\ArrowFunction
+		) {
+			$type = $node->returnType;
+		}
+
+		if (!$type instanceof Node\Identifier) {
+			return;
+		}
+
+		if (!in_array(strtolower($type->name), ['null', 'false', 'true'], true)) {
+			return;
+		}
+
+		$this->require(self::PHP_8_2, 'standalone "null", "false" or "true" types');
+	}
+
+	private function require(int $versionId, string $reason): void
+	{
+		if ($this->requiredVersionId !== null && $this->requiredVersionId >= $versionId) {
+			return;
+		}
+
+		$this->requiredVersionId = $versionId;
+		$this->reason = $reason;
+	}
+
+}

tests/PHPStan/Analyser/nsrt/array-key-exists-on-subtracted.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 namespace ArrayKeyExistsSubtracted;
 

tests/PHPStan/Analyser/nsrt/array-map.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.1
 namespace ArrayMap;
 
 use function array_map;

tests/PHPStan/Analyser/nsrt/array_values.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 namespace ArrayValues;
 

tests/PHPStan/Analyser/nsrt/bug-10037.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.2
 
 declare(strict_types = 1);
 

tests/PHPStan/Analyser/nsrt/bug-12691.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
 
 namespace Bug12691;
 

tests/PHPStan/Analyser/nsrt/bug-13061.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
 
 namespace Bug13061;
 

tests/PHPStan/Analyser/nsrt/bug-13828.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.3
 namespace Bug13828;
 
 use function PHPStan\Testing\assertType;

tests/PHPStan/Analyser/nsrt/bug-13872.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.1
 namespace Bug13872;
 
 use function is_array;

tests/PHPStan/Analyser/nsrt/bug-14772.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 declare(strict_types = 1);
 

tests/PHPStan/Analyser/nsrt/bug-14774.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
 
 namespace Bug14774;
 

tests/PHPStan/Analyser/nsrt/bug-4890-php8.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 namespace Bug4890Php8;
 

tests/PHPStan/Analyser/nsrt/bug-6904.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
 
 namespace Bug6904;
 

tests/PHPStan/Analyser/nsrt/bug-7698.php

@@ -1,4 +1,4 @@
-<?php
+<?php // lint >= 8.1
 
 namespace Bug7698;
 

tests/PHPStan/Analyser/nsrt/bug-7944.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 namespace Bug7944;
 

tests/PHPStan/Analyser/nsrt/bug-nullsafe-prop-static-access.php

@@ -1,4 +1,4 @@
-<?php // lint >= 8.0
+<?php // lint >= 8.1
 
 declare(strict_types=1);
 

tests/PHPStan/Analyser/nsrt/class-constant-narrowing.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
 
 namespace ClassConstantNarrowing;
 

tests/PHPStan/Analyser/nsrt/discussion-13395.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.2
+
+declare(strict_types = 1);
 
 namespace Discussion13395;
 

tests/PHPStan/Analyser/nsrt/ds-copy.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.1
 namespace DsCopy;
 
 use Ds\Collection;

tests/PHPStan/Analyser/nsrt/override-property-union-type-with-tag-subtype.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.1
 namespace OverridePropertyUnionTypeWithTagSubtype;
 
 use function PHPStan\Testing\assertType;

tests/PHPStan/Analyser/nsrt/static-late-binding.php

@@ -1,5 +1,4 @@
-<?php
-
+<?php // lint >= 8.1
 namespace StaticLateBinding;
 
 use function PHPStan\Testing\assertType;