feat: add dynamic parameter type extensions

[calebdw]

Closes phpstan/phpstan#11707, closes phpstan/phpstan#12585

Supersedes #3828, supersedes #3131, supersedes #3823

Hello!

This adds generalized dynamic parameter type extensions and deprecates the parameter closure type extensions per phpstan/phpstan#11707 (comment).

This also fixes the return.type and the argument.type errors described in phpstan/phpstan#12585 when the parameter type is overridden via the extension.

Note

This currently only works for array and closure arguments, if support is desired for other argument types in the future then that will have to be added.

CC: @canvural, @Neol3108

Thanks!

[phpstan-bot]

This pull request has been marked as ready for review.

[canvural]

I tested it by porting my previous implementation for Larastan to this one, and looks like it works fine! Will try to implement more use cases and see if I can find any bugs. Also will try to test it on real projects.But so far so good. Thanks for this!

I'll also try to review this PR (though Ondrej would do a better job 😄 )

[ondrejmirtes]

This looks solid, just a few questions as a start, will do deep review later 👍

[canvural]

@calebdw @ondrejmirtes Sorry to bother you, but I wanted to ask how we can move this forward? I'm really interested in this feature.

[calebdw]

No worries, just been busy with personal life, I'll try to get to the comments soon

[calebdw]

@ondrejmirtes, @canvural, sorry it took so long to address these comments---just been busy with personal life but hoping to move this forward now 🙏

[CamKemBell]

@calebdw - is this still planned on going ahead? Does this fix the issue with using whereHas with custom builders?

I've seen multiple projects now look to using custom builders since the implementation of the attribute & official support from Laravel last year, only to find issues when trying to type the arguments in eloquent method for type hints / auto complete, etc.

https://laravel-news.com/defining-a-dedicated-query-builder-in-laravel-12-with-php-attributes

In the meantime, we have been using whereRelation, which compiles to whereHas under the hood, but it would be nice to use whereHas directly.

[dnyg]

My team are also eagerly awaiting the outcome of this PR! Hope it can be pushed forward 🙏

[calebdw]

@CamKemBell, yes I just rebased and resolved all the conflicts

@ondrejmirtes, this is ready to review 👍

[dnyg]

What is the status on this PR?

[VincentLanglet]

Hi @calebdw sorry for the delay there is now more review for the PHPStan codebase.

Are you still interested by the PR ?
There is a lot of conflict, can you solve them please ?

Thanks !

[staabm]

I think it looks mostly good, a few questions

• if I did not miss it, it seems none of the tests is covering a error case?
• $overriddenType is passed thru a lot of handlers. I think we should have a few more tests which show that the overridden type gets correctly passed thru complex expressions
• I wonder if we really need end-to-end test-cases only or whether we could at least have some in-phpunit suite tests (these are easier to run, debug and maintain)
• you should look into issue-bot results and judge whether these are expected/related (some of them might go-away after rebase)
• we need this PR to target 2.2.x

[canvural]

@calebdw Would you have time to address the comments? Or if you allow, I can open another PR with your code and fix there.

[calebdw]

Yes, sorry been busy---I'll get to this shortly

[github-advanced-security]

zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[canvural]

Tested the latest PHAR, still works alright 👍🏽 Static analysis fails on CI looks legit though. But didn't happen at runtime 🤔 Maybe didn't hit that code path.

[CamKemBell]

Would love to see this over the line...

[canvural]

Can I sponsor/pay someone to bring this over the finish line? Resolving conflicts <--> wait for review loop doesn't seem to end 😄

// @ondrejmirtes @staabm @VincentLanglet

[calebdw]

@staabm,

if I did not miss it, it seems none of the tests is covering a error case?

I've added tests

$overriddenType is passed thru a lot of handlers. I think we should have a few more tests which show that the overridden type gets correctly passed thru complex expressions

Same here, added tests

I wonder if we really need end-to-end test-cases only or whether we could at least have some in-phpunit suite tests (these are easier to run, debug and maintain)

The existing DynamicParameterTypeExtensionClosuresTest and DynamicParameterTypeExtensionArraysTest are already PHPUnit TypeInferenceTestCase tests (not just e2e). The e2e tests are supplementary for integration validation.