Closed
Add opt-in transitive package attribution to dependency reachability#1118
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
Copilot
AI
changed the title
[WIP] Update dependency reachability aspect for Envoy attribution
Add opt-in transitive package attribution to dependency reachability
Aug 24, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
phlax
force-pushed
the
bazel-deps-matrix
branch
4 times, most recently
from
August 25, 2026 13:28
67a14cb to
856fee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependency_reachabilityonly emitted direct cross-repo consumers, so downstream users could not attribute an external repository to main-repo packages that reached it through shared internal code. In Envoy this under-attributed extension consumers and made a reverse "extensions:entry is actually used" check unsound.Add transitive package attribution, not full intra-repo edge recording
attribution_patternsondependency_reachability.attributed_packagesin the JSON, with:packagerootsproduction(falsemeans attribution exists only via testonly paths)Keep the default path zero-cost
attribution_patterns = []/ unset:attributed_packagesis omittedPreserve existing reachability semantics
productionmerges with logical ORDocument the intended downstream usage
Add regression coverage for the attribution shape
Example:
This keeps the output sized by the number of relevant packages, not by the full set of intra-repo edges, while giving downstream consumers enough information to attribute external repos transitively.