Skip to content

Instance count is only updated if geometry is dirty #426

Description

@vorg

cachedGeom.instances = geometry.instances;

Forcing me to do geometry spreads

psEntity.geometry.instances = particleSystem.count;
        psEntity.geometry = {
          ...psEntity.geometry,
        };

This is too error prone and the assignment of instances, count and primitive should be taken out of if (geometryDirty) check

cachedGeom.instances = geometry.instances;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions