PMM-15302 Remove ssh settings tab in HA mode - #5744
Open
matejkubinec wants to merge 2 commits into
Open
Conversation
matejkubinec
marked this pull request as ready for review
August 7, 2026 13:36
matejkubinec
requested review from
fabio-silva and
mattiasimonato
and removed request for
a team
August 7, 2026 13:36
WalkthroughChangesHA-aware SSH settings access
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx (1)
49-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the project route constant.
Navigatehardcodes"/settings"at Line 50. Use the settings-route constant fromui/apps/pmm/src/lib/constants.tsinstead of embedding this path.As per coding guidelines, use constants from
ui/apps/pmm/src/lib/constants.tsinstead of embedding URL strings.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx` around lines 49 - 50, Update the redirect in SshKeyForm’s haStatus handling to use the existing settings-route constant from constants.ts instead of the hardcoded "/settings" path, preserving the current Navigate behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx`:
- Around line 49-52: Make HA enforcement fail closed across the SSH settings
route: in ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx lines
15-24, expose the HA query readiness and error state, and in lines 49-52 allow
the form only for confirmed Disabled status while blocking or redirecting
pending, error, and Enabled states. In
ui/apps/pmm/src/pages/settings/Settings.tsx lines 29 and 70-76, propagate
readiness to the parent and gate or redirect direct SSH-route content rather
than merely hiding the tab. In ui/apps/pmm/src/pages/settings/Settings.test.tsx
lines 97-103, add a co-located direct-route test without mocking SshKeyForm that
verifies unknown HA status cannot render the form.
---
Nitpick comments:
In `@ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx`:
- Around line 49-50: Update the redirect in SshKeyForm’s haStatus handling to
use the existing settings-route constant from constants.ts instead of the
hardcoded "/settings" path, preserving the current Navigate behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1d4f2c2e-2827-4c3f-b0da-62270b39c51a
📒 Files selected for processing (3)
ui/apps/pmm/src/pages/settings/Settings.test.tsxui/apps/pmm/src/pages/settings/Settings.tsxui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
percona/pmm-qa(manual)percona/pmm(manual)
Comment on lines
+49
to
+52
| if (haStatus?.status === 'Enabled') { | ||
| return <Navigate to="/settings" />; | ||
| } | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make HA enforcement fail closed for direct SSH routes.
The parent and child checks do not make one fail-closed decision. The tab disappears, but a direct route can still render and submit the form while HA status is unknown.
ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx#L49-L52: allow the form only after a confirmedDisabledresponse; block or redirect pending and error states.ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx#L15-L24: expose the query readiness and error state required by the guard.ui/apps/pmm/src/pages/settings/Settings.tsx#L29-L29: keep the parent aware of HA-query readiness for direct-route handling.ui/apps/pmm/src/pages/settings/Settings.tsx#L70-L76: gate the SSH content or redirect/settings/ssh-key, not only remove the tab.ui/apps/pmm/src/pages/settings/Settings.test.tsx#L97-L103: add a direct-route assertion without theSshKeyFormmock, or add it in a co-located form test.
As per coding guidelines, co-locate Vitest tests with the UI code they cover.
📍 Affects 3 files
ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx#L49-L52(this comment)ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx#L15-L24ui/apps/pmm/src/pages/settings/Settings.tsx#L29-L29ui/apps/pmm/src/pages/settings/Settings.tsx#L70-L76ui/apps/pmm/src/pages/settings/Settings.test.tsx#L97-L103
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx` around
lines 49 - 52, Make HA enforcement fail closed across the SSH settings route: in
ui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsx lines 15-24,
expose the HA query readiness and error state, and in lines 49-52 allow the form
only for confirmed Disabled status while blocking or redirecting pending, error,
and Enabled states. In ui/apps/pmm/src/pages/settings/Settings.tsx lines 29 and
70-76, propagate readiness to the parent and gate or redirect direct SSH-route
content rather than merely hiding the tab. In
ui/apps/pmm/src/pages/settings/Settings.test.tsx lines 97-103, add a co-located
direct-route test without mocking SshKeyForm that verifies unknown HA status
cannot render the form.
Source: Coding guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15302
Feature build: SUBMODULES-4515