Revert "PMM-15180 Replace local custom SVG icons with peak-ui and MUI… - #5741
Merged
Conversation
fabio-silva
marked this pull request as ready for review
August 7, 2026 09:38
fabio-silva
requested review from
matejkubinec and
mattiasimonato
and removed request for
a team,
matejkubinec and
mattiasimonato
August 7, 2026 09:38
WalkthroughThe PMM UI replaces ChangesPercona UI migration
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx (1)
5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep MRT types on the same Percona UI table boundary.
Both files now use
Tablefrom@percona/percona-ui, but their MRT types are split between the shared package and directmaterial-react-tableimports. Percona UI 1.0.23 re-exports the relevant types from its table entry point. Move each type import to the shared package to prevent dependency-version drift. (github.com)
ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx#L5-L5: MoveMRT_RowandMaterialReactTablePropsfrom Lines 1-4 into the@percona/percona-uiimport.ui/apps/pmm/src/pages/alerting/status/table/AlertStatusTable.tsx#L1-L2: MoveMRT_Rowfrom Line 2 into the@percona/percona-uiimport.As per coding guidelines: “Prefer existing dependencies; justify new dependencies and ensure AGPL-3-compatible licensing.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx` at line 5, Keep MRT types on the shared Percona UI boundary: in ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx lines 1-5, move MRT_Row and MaterialReactTableProps into the `@percona/percona-ui` import and remove their direct material-react-table imports; in ui/apps/pmm/src/pages/alerting/status/table/AlertStatusTable.tsx lines 1-2, move MRT_Row into the `@percona/percona-ui` import and remove its direct import. Preserve the existing Table and useNavigableRows usage.Source: Coding guidelines
ui/apps/pmm/src/contexts/navigation/navigation.constants.ts (1)
22-22: 🎯 Functional Correctness | 🔵 TrivialComplete the required UI validation before merge.
These edits change user-visible navigation and account flows. Run
cd ui && make lint. Then verify the changed navigation entries on a live PMM server with real data in light and dark modes. Capture evidence for the migrated icons and navigation behavior.As per coding guidelines, unit tests are insufficient for user-visible changes; run PMM on a live server and verify behavior against real data with evidence.
Also applies to: 37-54, 123-141, 191-209, 237-249, 296-296, 306-306, 317-377, 388-399, 409-416, 466-466, 535-542, 558-558, 588-588, 621-621, 681-681, 717-717, 747-755, 782-782, 791-791, 804-804
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/apps/pmm/src/contexts/navigation/navigation.constants.ts` at line 22, Run the required UI validation with cd ui && make lint, then start PMM against a live server with real data and verify every changed navigation and account-flow entry in both light and dark modes. Capture evidence showing the migrated icons and resulting navigation behavior before merge.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ui/apps/pmm/src/contexts/navigation/navigation.constants.ts`:
- Line 22: Run the required UI validation with cd ui && make lint, then start
PMM against a live server with real data and verify every changed navigation and
account-flow entry in both light and dark modes. Capture evidence showing the
migrated icons and resulting navigation behavior before merge.
In `@ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx`:
- Line 5: Keep MRT types on the shared Percona UI boundary: in
ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx lines 1-5, move
MRT_Row and MaterialReactTableProps into the `@percona/percona-ui` import and
remove their direct material-react-table imports; in
ui/apps/pmm/src/pages/alerting/status/table/AlertStatusTable.tsx lines 1-2, move
MRT_Row into the `@percona/percona-ui` import and remove its direct import.
Preserve the existing Table and useNavigableRows usage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a3dcd36b-7e46-4640-b72f-985a0ef54e00
⛔ Files ignored due to path filters (50)
ui/apps/pmm/src/icons/account.svgis excluded by!**/*.svgui/apps/pmm/src/icons/alerts.svgis excluded by!**/*.svgui/apps/pmm/src/icons/arrow-link.svgis excluded by!**/*.svgui/apps/pmm/src/icons/backups.svgis excluded by!**/*.svgui/apps/pmm/src/icons/bottom-panel-close.svgis excluded by!**/*.svgui/apps/pmm/src/icons/bottom-panel-open.svgis excluded by!**/*.svgui/apps/pmm/src/icons/browse-dashboards.svgis excluded by!**/*.svgui/apps/pmm/src/icons/check.svgis excluded by!**/*.svgui/apps/pmm/src/icons/cluster.svgis excluded by!**/*.svgui/apps/pmm/src/icons/collapse-content.svgis excluded by!**/*.svgui/apps/pmm/src/icons/configuration.svgis excluded by!**/*.svgui/apps/pmm/src/icons/dashboards.svgis excluded by!**/*.svgui/apps/pmm/src/icons/dynamic-feed.svgis excluded by!**/*.svgui/apps/pmm/src/icons/electric-bolt-off.svgis excluded by!**/*.svgui/apps/pmm/src/icons/electric-bolt.svgis excluded by!**/*.svgui/apps/pmm/src/icons/expand-content.svgis excluded by!**/*.svgui/apps/pmm/src/icons/explore.svgis excluded by!**/*.svgui/apps/pmm/src/icons/file-download.svgis excluded by!**/*.svgui/apps/pmm/src/icons/graph-6.svgis excluded by!**/*.svgui/apps/pmm/src/icons/haproxy.svgis excluded by!**/*.svgui/apps/pmm/src/icons/help-fill.svgis excluded by!**/*.svgui/apps/pmm/src/icons/help.svgis excluded by!**/*.svgui/apps/pmm/src/icons/high-availability.svgis excluded by!**/*.svgui/apps/pmm/src/icons/home.svgis excluded by!**/*.svgui/apps/pmm/src/icons/inventory.svgis excluded by!**/*.svgui/apps/pmm/src/icons/knowledge-base.svgis excluded by!**/*.svgui/apps/pmm/src/icons/memory.svgis excluded by!**/*.svgui/apps/pmm/src/icons/my-organization.svgis excluded by!**/*.svgui/apps/pmm/src/icons/network.svgis excluded by!**/*.svgui/apps/pmm/src/icons/operating-system.svgis excluded by!**/*.svgui/apps/pmm/src/icons/overview.svgis excluded by!**/*.svgui/apps/pmm/src/icons/pause.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona-intelligence.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona-mo.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona-my.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona-po.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona-va.svgis excluded by!**/*.svgui/apps/pmm/src/icons/percona.svgis excluded by!**/*.svgui/apps/pmm/src/icons/play-arrow.svgis excluded by!**/*.svgui/apps/pmm/src/icons/proxysql.svgis excluded by!**/*.svgui/apps/pmm/src/icons/qan.svgis excluded by!**/*.svgui/apps/pmm/src/icons/real-time-database-off.svgis excluded by!**/*.svgui/apps/pmm/src/icons/refresh.svgis excluded by!**/*.svgui/apps/pmm/src/icons/search.svgis excluded by!**/*.svgui/apps/pmm/src/icons/sign-out.svgis excluded by!**/*.svgui/apps/pmm/src/icons/summary.svgis excluded by!**/*.svgui/apps/pmm/src/icons/theme-dark.svgis excluded by!**/*.svgui/apps/pmm/src/icons/theme-light.svgis excluded by!**/*.svgui/apps/pmm/src/icons/users-and-access.svgis excluded by!**/*.svgui/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (40)
ui/apps/pmm/package.jsonui/apps/pmm/src/App.tsxui/apps/pmm/src/components/app-bar/AppBar.tsxui/apps/pmm/src/components/details-pane/DataPoint.tsxui/apps/pmm/src/components/feature-check/FeatureCheck.tsxui/apps/pmm/src/components/ha-icon/HighAvailabilityIcon.tsxui/apps/pmm/src/components/icon/Icon.constants.tsui/apps/pmm/src/components/sidebar/nav-item/SidebarNavItem.test.tsxui/apps/pmm/src/components/sidebar/nav-item/SidebarNavItem.tsxui/apps/pmm/src/components/sidebar/nav-item/nav-item-icon/NavItemIcon.test.tsxui/apps/pmm/src/contexts/navigation/navigation.constants.tsui/apps/pmm/src/contexts/navigation/navigation.utils.tsxui/apps/pmm/src/hooks/theme.tsui/apps/pmm/src/pages/alerting/status/AlertsPage.tsxui/apps/pmm/src/pages/alerting/status/details-pane/AlertDetailsPane.tsxui/apps/pmm/src/pages/alerting/status/details-pane/details/AlertDetailsTab.tsxui/apps/pmm/src/pages/alerting/status/details-pane/raw-data/RawDataTab.tsxui/apps/pmm/src/pages/alerting/status/table/AlertStatusTable.constants.tsxui/apps/pmm/src/pages/alerting/status/table/AlertStatusTable.tsxui/apps/pmm/src/pages/help-center/help-center-card/HelpCenterCard.tsxui/apps/pmm/src/pages/help-center/help-center-card/HelpCenterCard.types.tsui/apps/pmm/src/pages/rta/overview/RealtimeOverview.tsxui/apps/pmm/src/pages/rta/overview/auto-refresh-select/AutoRefreshSelect.tsxui/apps/pmm/src/pages/rta/overview/details-pane/DetailsPane.tsxui/apps/pmm/src/pages/rta/overview/details-pane/QueryAndDetails.tsxui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsxui/apps/pmm/src/pages/rta/overview/table/query-cell/QueryCell.tsxui/apps/pmm/src/pages/rta/selection/empty-state/RealtimeSelectionViewerEmptyState.tsxui/apps/pmm/src/pages/rta/sessions/sessions-table/SessionsTable.tsxui/apps/pmm/src/pages/rta/sessions/sessions-table/modal-new-session/NewSessionModal.tsxui/apps/pmm/src/pages/rta/sessions/sessions-table/modal-stop-multiple-sessions/StopMultipleSessionsModal.tsxui/apps/pmm/src/pages/rta/sessions/sessions-table/modal-stop-session/StopSessionModal.tsxui/apps/pmm/src/pages/settings/components/advanced/AdvancedSettingsForm.tsxui/apps/pmm/src/pages/settings/components/metrics-resolution/MetricsResolutionForm.tsxui/apps/pmm/src/pages/settings/components/ssh-key/SshKeyForm.tsxui/apps/pmm/src/pages/update-clients/UpdateClients.tsxui/apps/pmm/src/pages/updates/change-log/code-block/CodeBlock.tsxui/apps/pmm/src/pages/updates/change-log/release-notes/ReleaseNotes.constants.tsxui/apps/pmm/src/utils/testWrapper.tsxui/apps/pmm/vitest.config.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
percona/pmm-qa(manual)percona/pmm(manual)
pmcf-percona
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e6737f.