Skip to content

PMM-15206: RTA host filter substring matching - #5734

Open
mattiasimonato wants to merge 2 commits into
mainfrom
PMM-15206-rta-host-filter
Open

PMM-15206: RTA host filter substring matching#5734
mattiasimonato wants to merge 2 commits into
mainfrom
PMM-15206-rta-host-filter

Conversation

@mattiasimonato

@mattiasimonato mattiasimonato commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Ticket number: PMM-15206

Feature build: SUBMODULES-4512

The Host column had no filterFn, so material-react-table used its fuzzy default and matched the typed value as a subsequence instead of a substring.
Setting filterFn: 'contains' makes Host behave like the Query column, which already used it.

@mattiasimonato
mattiasimonato marked this pull request as ready for review August 5, 2026 14:57
@mattiasimonato
mattiasimonato requested a review from a team as a code owner August 5, 2026 14:57
@mattiasimonato
mattiasimonato requested review from fabio-silva and matejkubinec and removed request for a team August 5, 2026 14:57
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

Host filtering

Layer / File(s) Summary
Host filter behavior and validation
ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.constants.tsx, ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.test.tsx
The host column now uses filterFn: 'contains' instead of MRT’s default fuzzy filtering. Tests verify substring matching and case-insensitive matching.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the RTA host filter change and the new substring-matching behavior.
Description check ✅ Passed The description includes the required ticket and feature build, and clearly explains the filter behavior change.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants