-
Notifications
You must be signed in to change notification settings - Fork 226
PMM-15288 Migrate UI toolchain to pnpm + oxlint/oxfmt #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nachodd
wants to merge
7
commits into
main
Choose a base branch
from
PMM-15288
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2d4eb5a
PMM-15288 Migrate UI toolchain to pnpm + oxlint/oxfmt
nachodd dfbb14a
PMM-15288 Address review comments on the toolchain migration
nachodd d307350
PMM-15288 Activate the oxlint plugins the rules rely on
nachodd f466863
Merge branch 'main' into PMM-15288
nachodd 2d7ab6e
PMM-15288 Scope the UI rows in AGENTS.md to the whole workspace
nachodd 91e792c
Merge branch 'main' into PMM-15288
fabio-silva 8721ffd
Merge branch 'main' into PMM-15288
nachodd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | ||
| "singleQuote": true, | ||
| "trailingComma": "es5", | ||
| "tabWidth": 2, | ||
| "semi": true, | ||
| "printWidth": 80, | ||
| "bracketSpacing": true, | ||
| "arrowParens": "always", | ||
| "endOfLine": "lf", | ||
| "ignorePatterns": [ | ||
| "dist", | ||
| "node_modules", | ||
| "pnpm-lock.yaml", | ||
| "storybook-static", | ||
| "**/.config/**" | ||
| ] | ||
| } |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall this dir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,5 @@ | ||
| { | ||
| "typescript.preferences.autoImportSpecifierExcludeRegexes": ["^@mui/[^/]+$"], | ||
| "eslint.workingDirectories": [ | ||
| { | ||
| "mode": "auto" | ||
| } | ||
| ] | ||
| "oxc.configPath": "oxlintrc.json", | ||
| "oxc.fmt.experimental": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,33 @@ | ||
| .PHONY: dev ci format format-check lint test setup build release clean | ||
|
|
||
| dev: | ||
| yarn dev | ||
| pnpm dev | ||
|
|
||
| ci: setup format-check lint test build | ||
|
|
||
| format: setup | ||
| yarn format | ||
| pnpm format | ||
|
|
||
| format-check: setup | ||
| yarn format:check | ||
| pnpm format:check | ||
|
|
||
| lint: setup | ||
| yarn lint | ||
| pnpm lint | ||
|
|
||
| test: setup | ||
| yarn test | ||
| pnpm test | ||
|
|
||
| setup: | ||
| yarn install | ||
| # corepack ships with Node 22 and resolves pnpm from the `packageManager` | ||
| # field in package.json, so the version is pinned in exactly one place. | ||
| # The sudo fallback covers images where corepack's shim dir is root-owned. | ||
| corepack enable pnpm 2>/dev/null || sudo corepack enable pnpm | ||
| pnpm install | ||
|
nachodd marked this conversation as resolved.
|
||
|
|
||
| build: setup | ||
| yarn build | ||
| pnpm build | ||
|
|
||
| release: build | ||
|
|
||
| clean: | ||
| yarn clean | ||
| pnpm clean | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.