Fix PMM-T2227 tarball upgrade check by trimming version lookup - #1147
Merged
Conversation
WalkthroughThe changes normalize the released client version used by the tarball upgrade test and constrain the Linode runner label prefix before adding its random suffix. ChangesClient version handling
Linode runner labels
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
The docker-hub tag lookup kept its trailing newline, so the assertion on the installed client asked for "3.9.0\n" instead of "3.9.0". That only ever matched while the released tarball reported a bare version: the tarball now served for 3.9.0 reports 3.9.0-v3-83cf42bbe, so the version number is no longer at end of line and the check fails every night -- masked in CI because the test is quarantined in Launchable and the test step is run with '|| true'. Trim it, matching the latestVersion lookup a few lines below, so the assertion checks that the output contains the version number and the value interpolated into the install command carries no stray newline. Signed-off-by: Claude <noreply@anthropic.com>
travagliad
force-pushed
the
claude/affectionate-archimedes-sx5rh5
branch
from
August 7, 2026 19:48
da96189 to
dfa6055
Compare
yurkovychv
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures fixed (investigator)
PMM Integration Tests, jobCLI / Integration / Generic)cli/tests/generic.spec.ts:571/@generic— PMM-T2227 - Verify tarball upgradeWhat failed
The nightly
integration-cli-tests.ymlrun reports green, but the test step contains a real failure that Launchable hides — the test is quarantined, solaunchable gateprintsPASSED | Quarantined (Ignored) 1 | Actionable Failures 0, and the test step itself runs with|| true. The same 1-failed/1-quarantined pattern is in the previous nightly run (31059341390) too, so this is a persistent failure, not a flake.Why
latestReleasedVersioncame from the docker-hub tag lookup without.trim(), so it carried the trailing newline andoutContainssearched for"3.9.0\n"rather than"3.9.0". That only ever matched while the released tarball reported a bare version number at end of line. The tarball the install script pulls for a released version (downloads.percona.com/downloads/TESTING/pmm/pmm-client-3.9.0.tar.gz) now reports3.9.0-v3-83cf42bbe, so the version number is no longer at end of line and the assertion fails every run.The client version itself is correct —
3.9.0-v3-<sha>is ordinary build metadata for a non-final build — so this is a test bug, not a PMM defect. ThelatestVersionlookup a few lines below already used.trim(); this brings the released-version lookup in line with it. Trimming also removes the stray newline that was being interpolated into theinstall_tarball -v <version>command.Reproduced and verified
Throwaway Linode VM, PMM Server
perconalab/pmm-server:3-dev-latest, clientlatest-tarball, host client +--database pdpgsql=16(what the test'sbeforeAllrequires), followingrunner-integration-cli-tests.yml:main— failed with exactly the CI error above, same expected/received strings✓ 1 tests/generic.spec.ts:571:7 › PMM-T2227 - Verify tarball upgrade @generic (23.4s)/1 passed; the upgrade path ran through: installed3.9.0-v3-83cf42bbe, upgraded to3.9.1-v3-c24fc62f0, agent reconnected with a new PID🤖 Generated with Claude Code
https://claude.ai/code/session_01EpWmLrQsBTxn4GqBYspq1n