Repository navigation
Give e2e mock ramps an expiry so SELL journeys pass the start-deadline guard - #1399
Merged
Merged
Conversation
…e guard The SELL start-deadline guard from #1393 fails closed when the ramp has no expiresAt, so every mocked SELL journey ended on the "sale expired" error. Mirror the API's createdAt + 15 min window.
✅ Deploy Preview for vrtx-dashboard canceled.
|
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
All 5 SELL e2e journeys (BRL, USD, MXN, COP, ARS) fail on
staging(591d11f). The e2e mockbuildRampProcessinapps/frontend/e2e/support/mockBackend.tsreturned a ramp with noexpiresAt. The SELL start-deadline guard added in #1393 (sign.actor.ts) fails closed whenexpiresAtis missing, so every mocked SELL journey ended on "This sale expired before your funds were sent." instead of the success screen.Change
The mock ramp now gets
expiresAt = now + 15 min, the same window the API sets (createdAt + RAMP_START_EXPIRATION_TIME_SECONDS,apps/api/src/constants/constants.ts). The guard itself is unchanged; failing closed is intended.Verification
bun test:e2einapps/frontend: