Conversation
Negative target discounts were silently disabled when the subsidy gates changed from '!== 0' to '.gt(0)' (PR #1232, later copied into the AlfredPay sell path in PR #1327). A negative target is meant to keep subsidizing, just only up to a rate worse than the reference rate. All subsidy sites now share hasConfiguredTargetDiscount, which also handles Sequelize DECIMAL strings. The dynamic difference now re-clamps into the partner's current [min, max] range on every read and consumption, so admin range changes apply on the next quote instead of drifting there one deltaD step at a time; fresh state starts at the clamped minimum. On a min > max misconfiguration the max cap wins, keeping the cost ceiling authoritative.
Avenia subaccount limit rejections on ramp registration previously collapsed into the generic validation_error bucket, making it impossible for monitoring to distinguish an exhausted monthly provider limit from genuine client-side request bugs. Carry a stable cause code on the thrown APIError so events record errorType provider_limit_exceeded and the 400 response exposes the code to API clients.
…-range Restore negative target discounts, apply dynamic range changes immediately, default dashboard to Base
✅ Deploy Preview for vortexfi canceled.
|
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard canceled.
|
…ded-error-type Classify provider limit rejections with a stable provider_limit_exceeded error code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.