Fix: stop the plugin subtree from running the project's skill copy (#523)

[abdulwahabone]

Fixes #523.

The ./plugin subtree shipped 44 markdown instructions pointing at node .claude/skills/impeccable/scripts/..., a path inside the user's project: a plugin-only install got MODULE_NOT_FOUND, and a dual install silently ran the project's older skill copy.

The build now rewrites the plugin subtree's markdown to the node <skill-base-dir>/scripts/... form (new scripts/lib/plugin-paths.js, called from build.js right after the plugin copy; .md files only, hook-admin.mjs keeps its project-scoped paths on purpose). The plugin copy drops the Bash(node ...) pre-approval entirely: no frontmatter rule can bind approval to the loaded plugin root, and a wildcard pattern would auto-approve same-shaped paths outside the plugin, so script runs go through the normal Bash confirmation. A drift guard (verifyPluginSkillRewrite) fails build:release if the source wording the rewrite keys on changes. Rebased on main and adapted to #544's base-directory Setup wording.

Validation: bun run test green, including the plugin loader E2E installing the rewritten subtree into a real sandboxed Claude Code; new tests/plugin-paths.test.js (10 tests); zero project-relative script paths remain in plugin markdown (was 44). The regenerated plugin/**/*.md files are included intentionally and rebuild byte-identically from bun run build:release.

Drafted with AI assistance; reviewed and submitted by a maintainer.

Made with Cursor

[greptile-apps]

Greptile Summary

The plugin now runs bundled helpers from its loaded skill directory and removes the broad Node-script permission. The previously reported wildcard permission issue was disproved by executing the same matching repository-controlled script path against the current generated plugin: its frontmatter contains no Bash(node ...) preapproval.

Confidence Score: 5/5

No blocking failure remains.

The matching repository-controlled script path was exercised against the current plugin configuration, which contains no Node-script preapproval; focused rewrite tests and the plugin-generating build also completed successfully.

T-Rex Logs

What T-Rex did

• Ran the plugin-paths test suite and confirmed all 10 tests passed.
• Compared the prior and current generated plugin frontmatter against the repository-controlled script path and noted that legacy checks were removed while only Bash(npx impeccable *) remains.
• Built the project and verified the rewrite guard was preserved, with the build completing successfully.
• Captured the validation script source and all observed command outputs as evidence and archived them for audit.
• Recorded the before and after evidence records showing the configuration state changes, including the legacy flags and the limited tool set.

_{Ran code and verified through T-Rex}

_{Reviews (2): Last reviewed commit: "Drop the node pre-approval from the plug..." | Re-trigger Greptile}