Skip to content

fix(payjoin-ffi): validate brew and llvm on macOS - #1776

Merged
benalleng merged 1 commit into
payjoin:masterfrom
AdamuAbba:ffi_javascript
Aug 7, 2026
Merged

fix(payjoin-ffi): validate brew and llvm on macOS#1776
benalleng merged 1 commit into
payjoin:masterfrom
AdamuAbba:ffi_javascript

Conversation

@AdamuAbba

Copy link
Copy Markdown
Contributor

Summary

  • commit - d33bc3c
    • the commit adds an early guard inside the Darwin + non-Nix-shell if block with a descriptive error message when brew or llvm are not installed

Closes #1773

hey @xstoicunicornx when you've got some time i'd appreciate that review. Thank you.

AI assistance disclosure

I consulted GitHub copilot to understand the codebase and most of the code was then generated using copilot inline completion

Pull Request Checklist

Please confirm the following before requesting review:

Signed-off-by: shytypes <abbaadamu302@icloud.com>

@xstoicunicornx xstoicunicornx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d33bc3c

Reviewed and tested locally. Update is straightforward guard against missing mac os dependencies brew and llvm.

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d33bc3c

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK d33bc3c

@benalleng
benalleng merged commit a250593 into payjoin:master Aug 7, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate Homebrew and LLVM prerequisites in generate_bindings.sh on macOS

4 participants