[2-week comment period thru 26/08/07] 1.0 CONTRIBUTING.md changes: PR/Issue Scope, SECURITY.md, Licensing - #1757
Open
DanGould wants to merge 3 commits into
Open
Conversation
GitHub surfaces this file in the Security tab and in the report-a- vulnerability flow, so private disclosure has a discoverable path instead of landing in the public issue tracker.
GitHub requests review from listed owners on every PR, and the file makes the maintainer set public and machine-readable. Enforcement via the require-review-from-code-owners branch protection setting is a separate decision.
Write down the norms a contributor needs while working in this repository.
Collaborator
Coverage Report for CI Build 29996669924Coverage remained the same at 86.374%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
|
Maybe worth taking this out of draft status? Draft PRs don't necessarily get looked at (I know that I tend to skip them). |
DanGould
marked this pull request as ready for review
July 29, 2026 17:35
Contributor
There was a problem hiding this comment.
Concept ACK
One suggestion on SECURITY.md: it currently lists only an email address for vulnerability reports. Since reports travel through several SMTP hops before reaching a maintainer, projects handling financial software often pair the contact email with a PGP public key or a link to one on a so reporters can encrypt sensitive details in transit.
Worth considering adding a fingerprint or key link alongside the email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we prepare for rust-payjoin 1.0 maturity and release, I'd like to make some operational policy explicit in CONTRIBUTING.md. Opening the change a 2-week community comment period.
I commit to responding to any substantial comments during the comment period.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.