Skip to content

CLAUDE.md added - #42

Open
michalkucharczyk wants to merge 1 commit into
mainfrom
mku-claude-md-added
Open

CLAUDE.md added#42
michalkucharczyk wants to merge 1 commit into
mainfrom
mku-claude-md-added

Conversation

@michalkucharczyk

Copy link
Copy Markdown
Contributor

CLAUDE.md added

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a couple of comments.

Comment thread CLAUDE.md
Comment on lines +8 to +9
TEST-DB: `postgres://tart:tart_password@localhost:5432/tart_test`
DB: `postgres://tart:tart_password@127.0.0.1:5432/tart_telemetry`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the first localhost and the second is 127.0.0.1? 🤔

Comment thread CLAUDE.md
Comment on lines +42 to +45
- Telemetry events: `../polkajam/crates/jam-std-common/src/telemetry.rs`
- JIP-3 spec: `../JIPs/JIP-3.md` (public: https://github.com/polkadot-fellows/JIPs/blob/main/JIP-3.md)
- polkajam implementation (node): `../polkajam/`
- Infinity plugin source (when stuck): `../grafana-infinity-datasource/`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This presumes the checkouts, what should the model do if they're not there? Better state the behavior explicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants