-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ir): carry argument paths, element values, cardinality and union depth across mixins #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1a537a2
feat(ir): carry argument paths, element values, cardinality and union…
claude eeb3624
fix(scan): keep an argument path off any frame it cannot name
claude 4faad42
fix(scan): tell an empty argument prefix apart from an unresolvable one
claude 2a623a1
fix(scan): hold the argument-object boundary at the request root
claude 827564e
feat(scan): address values inside map callbacks and on a stanza root
claude a5b6225
fix(ir): record an optional literal's value instead of addressing its…
claude df35ffe
fix(scan): rebase a mixin contribution like every other handed frame
claude 42a9045
test(scan): make the coverage guard look at variant-group attributes
claude c1ab69a
fix(scan): close three latent misreads at the builder boundary
claude c0cf801
feat(scan): rebase a mixin contribution onto the frame that named it
claude c33e3cf
fix(ir): keep a pinned payload's address, and refuse two addresses fo…
claude 20206f2
Merge origin/main into the request-builder batch
claude 2cc395d
fix(scan): shadow per scope, and withhold a sibling builder's fragment
claude b9007ce
feat(ir): address the request's addressee, and stop a wrapper claimin…
claude 60e5e55
fix(scan): key a mixin reach by its frame, and dedupe stanzas by addr…
claude 43a7e86
fix(scan): bound the mixin walk by module, and let a local `to` own i…
claude 03d67e2
fix(ir): withdraw an addressee's key when the chain disagrees about t…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says exactly one segment in an argument path is indexed, but nested repeated combinators legitimately produce multiple indexed segments. The committed
WASmaxOutPreKeysFetchMissingPreKeysRequestalready emitsuserArgs[] → deviceArgs[] → deviceId; a consumer following this guidance may reject that path or index only one level and place the device ID on the wrong object. Describelistas marking each segment whose corresponding combinator iterates, rather than asserting there can be only one per path.Useful? React with 👍 / 👎.