Skip to content

perf(binary): validate packed output with the wire path's validator #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 1 commit into from
Aug 6, 2026
Merged

perf(binary): validate packed output with the wire path's validator #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions wacore/binary/src/decoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,11 @@ impl<'a> Decoder<'a> {
pos -= 1;
}

// All output bytes are ASCII, so from_utf8 cannot fail.
let s = std::str::from_utf8(&buf[..pos]).expect("packed decode produced non-ASCII");
// Unlike `read_string`, which validates bytes that came off the wire,
// this validates bytes the tables above just wrote, so it can never
// fail. Keeping a check at all is cheap insurance against a future
// table edit; smoothutf8 is the same validator the wire path uses.
let s = smoothutf8::from_utf8(&buf[..pos]).expect("packed decode produced non-ASCII");
Ok(CompactString::from(s))
}

Expand Down