-
Notifications
You must be signed in to change notification settings - Fork 0
docs: document SqliteStore::share_for_device #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
242e013
docs: document SqliteStore::share_for_device
claude daaeaa1
docs: rewrite share_for_device sections in second person
claude b160802
docs: fix accuracy issues in share_for_device docs
claude 48ad1fd
docs: clarify PersistenceManager auto-provisions the device row
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you pass the returned store through the normal
PersistenceManagerinitialization path, it already checksbackend.exists()and callsbackend.create()when the scoped row is absent (concepts/storage.mdxlines 59–64). Telling users they must provision the row themselves is therefore incorrect, and the suggestedcreate_new_deviceAPI is not documented anywhere in the repository; clarify thatshare_for_deviceitself does not create the row, but normal client initialization does.Useful? React with 👍 / 👎.