-
Notifications
You must be signed in to change notification settings - Fork 0
docs: document stanza interception and DecryptedPayload event from whatsapp-rust#1239/#1240/#1241 #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
docs: document stanza interception and DecryptedPayload event from whatsapp-rust#1239/#1240/#1241 #492
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The "Interaction with Signal durability" claim that a claimed stanza involves "nothing decrypted, no session mutated, no prekey consumed" directly contradicts the sibling
add_stanza_interceptorsection in api/client.mdx (same PR stack), which states a claimed<message>"has already been decrypted or not by the time an interceptor sees it, exactly as the built-in handler would have found it". A plugin author reading both pages gets opposite guidance about whether claiming advances Signal state/prekeys, which undercuts the no-durability-contract rationale here. Reconcile the two: either the interceptor runs after decryption (keeping the client.mdx framing) and this section must not claim zero Signal work, or interception truly precedes all Signal work and client.mdx needs correcting.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same contradiction Greptile flagged on the
api/client.mdxside — fixed there in b58f0e4, so this line's framing ("nothing decrypted, no session mutated, no prekey consumed") is now the reconciled, correct account: interception truly precedes all Signal work. Nothing to change here inadvanced/plugins.mdx.Generated by Claude Code