Add full service IP Pool data to DB rack init type#10906
Open
bnaecker wants to merge 1 commit into
Open
Conversation
- Add `ServiceIpPoolConfig` to the database `RackInit` type. This includes the name / description of the pool, plus a constructor that validates the sequence of ranges (non-empty and all one version). - Remove hard-coded IP Pool construction from database `load_builtin_rack_data`, using the provided pool information instead. - Update test callers which assumed builtin pools
bnaecker
force-pushed
the
ben/add-service-ip-pool-config-to-rack-init
branch
from
July 23, 2026 02:53
fd86868 to
09c36a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceIpPoolConfigto the databaseRackInittype. This includes the name / description of the pool, plus a constructor that validates the sequence of ranges (non-empty and all one version).load_builtin_rack_data, using the provided pool information instead.