[20/n] [wicketd] make GetInventoryError::InvalidSpIdentifier carry the id#10885
Merged
sunshowers merged 3 commits intoJul 23, 2026
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
1 task
jgallagher
approved these changes
Jul 22, 2026
sunshowers
changed the base branch from
sunshowers/spr/main.20n-wicketd-make-getinventoryerrorinvalidspidentifier-carry-the-id
to
main
July 23, 2026 00:37
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
July 23, 2026 00:43
sunshowers
deleted the
sunshowers/spr/20n-wicketd-make-getinventoryerrorinvalidspidentifier-carry-the-id
branch
July 23, 2026 02:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified during #10857 review.
Also map it to a 400 (client-side error) rather than a 503 (server-side error).