fix(linter): false positve in no-unused-vars

[camc314]

fixes #10458

[camc314]

• fix(linter): false positve in no-unused-vars #10470 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10470 will not alter performance

_{Comparing c/04-17-fix_linter_false_positve_in_no-unused-vars (f0c1eff) with main (a42d85f)}

Summary

✅ 36 untouched benchmarks

[Dunqing]

Thanks! I do not fully understand how it works, but from the code, it looks like it can be simplified.

[Dunqing]

Merge activity

• Apr 17, 10:25 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 17, 10:25 PM EDT: Dunqing added this pull request to the Graphite merge queue.
• Apr 17, 10:29 PM EDT: Merged by the Graphite merge queue.

[camc314]

from the code, it looks like it can be simplified.

know how?

rust-lang/rust#138528 looks like 1.88, we should be able to use implicit deref ect.

so it'd end up (I think) like:

                    match left {
                        AssignmentTarget::AssignmentTargetIdentifier(id) => {
                            if id.name == name {
                                is_used_by_others = false;
                            } else {
                                 return false; // we can short-circuit
                             }
                         }
                         AssignmentTarget::TSAsExpression(ref TSAsExpression { expression, .. })
                         | AssignmentTarget::TSSatisfiesExpression(ref TSSatisfiesExpression { expression, .. })
                         | AssignmentTarget::TSSatisfiesExpression(ref TSSatisfiesExpression { expression, .. })
                         | AssignmentTarget::TSNonNullExpression(ref TSNonNullExpression { expression, .. })
                         | AssignmentTarget::TSTypeAssertion(ref TSTypeAssertion { expression, .. })
                         if expression.is_member_expression() =>
                         {
                             return false;
                         }