usockets(kqueue): stop a non-reading socket's read knote from waking the loop on data - #39949
Merged
Merged
Claude / Claude Code Review
completed
Aug 21, 2026 in 20m 12s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/net/socket.test.ts:4327-4346 |
peer socket not released via using before assertions |
Annotations
Check warning on line 4346 in test/js/bun/net/socket.test.ts
claude / Claude Code Review
peer socket not released via using before assertions
Nit: `peer` should be declared with `using` so the socket is released even if an earlier assertion (line 4332 or 4335) fails — REVIEW.md requires resource cleanup be registered *before* assertions, and this file already uses `using ... = await Bun.connect(...)` in ~10 other tests. Change `const peer` → `using peer` and drop the explicit `peer.end()`.
Loading