Skip to content

docs(sql): document timestamp without time zone decoded as UTC (fixes #39879) - #39911

Closed
deepshekhardas wants to merge 1 commit into
oven-sh:mainfrom
deepshekhardas:fix-39879-postgres-timestamp-docs
Closed

docs(sql): document timestamp without time zone decoded as UTC (fixes #39879)#39911
deepshekhardas wants to merge 1 commit into
oven-sh:mainfrom
deepshekhardas:fix-39879-postgres-timestamp-docs

Conversation

@deepshekhardas

Copy link
Copy Markdown

Fixes #39879

PostgreSQL imestamp without time zone (OID 1114) is decoded as UTC so text and binary paths agree and a bound Date round-trips regardless of host timezone. This differs from
ode-postgres/postgres.js/PGlite which decode as local time.

Previously the behavior was documented only in the MySQL section at docs/runtime/sql.mdx:1370, inside a trailing clause. A PostgreSQL user had no reason to read that section and the PostgreSQL docs said nothing, leading to silent offset shifts when migrating from pg.

Adds a dedicated imestamp without time zone note under PostgreSQL-Specific Features.

…ven-sh#39879)

PostgreSQL timestamp (OID 1114) is decoded as UTC so text and binary paths agree and bound Date round-trips regardless of host timezone. This differs from node-postgres/postgres.js/PGlite which decode as local time. Add PostgreSQL-specific note with callout.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0ea44f5b-fb34-4da3-b4b1-3158e4e019a8

📥 Commits

Reviewing files that changed from the base of the PR and between d4de65e and 1c2f0f0.

📒 Files selected for processing (1)
  • docs/runtime/sql.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Changes

PostgreSQL timestamp documentation

Layer / File(s) Summary
Document PostgreSQL timestamp behavior
docs/runtime/sql.mdx
Documents UTC decoding and Date round-tripping for timestamp without time zone, contrasts behavior with other drivers, and clarifies that timestamptz is unaffected.

Suggested reviewers: robobun, alii

Merge Risk: ⚪ Minimal · up to 1c2f0

This change only clarifies PostgreSQL timestamp decoding behavior in the documentation and introduces no production code or runtime behavior changes; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the PostgreSQL documentation change and references the related issue.
Description check ✅ Passed The description clearly explains the documentation change and rationale, although it omits the template headings and verification details.
Linked Issues check ✅ Passed The PR fulfills the coding-related documentation objectives in [#39879], including PostgreSQL discoverability, UTC decoding, driver differences, and round-trip rationale.
Out of Scope Changes check ✅ Passed The changes are limited to the requested PostgreSQL documentation update and contain no unrelated code or content.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the PR, and for the clear write-up of the facts.

#39879 is documented by #39881, which was opened a few hours earlier. After review, that PR now adds a top-level "Dates and time zones" section, so the rule appears in the page table of contents and is stated once for PostgreSQL and MySQL. The MySQL note links to it.

I folded the extra facts from this PR into #39881 (OID 1114, text and binary queries agree, PGlite). Commit b187c78 carries a Co-authored-by trailer with your name.

I am closing this PR in favor of #39881 to keep one change per issue. If you see a gap in the wording there, please comment on #39881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: timestamp without time zone decoding as UTC isn't documented in the PostgreSQL section

2 participants