usockets: report an out-of-descriptors event loop init as an error, not a crash - #39641
Open
robobun wants to merge 3 commits into
Open
usockets: report an out-of-descriptors event loop init as an error, not a crash#39641robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 19, 2026 in 13m 35s
Code review found 1 important issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/crash_handler/lib.rs:1334 |
PR description claims >> is now escaped in fd-limit messages, but the escaping change is missing |
Annotations
Check failure on line 1334 in src/crash_handler/lib.rs
claude / Claude Code Review
PR description claims >> is now escaped in fd-limit messages, but the escaping change is missing
The PR description says the Linux fd-limit messages "now escape" `>>`, but that hunk is missing from the diff — lines 1312 and 1355 still pass unescaped `>> /etc/sysctl.conf` to `pretty_error!`, whose tag rewriter silently drops bare `>`. Since this PR makes both branches reachable for the first time, users will now see the broken advice `sudo echo -e "..." /etc/sysctl.conf` (no redirection). Escape as `\>\>` at both sites.
Loading