valkey: fix null array, null CRLF, big number and blob error replies - #39544
Merged
Claude / Claude Code Review
completed
Aug 19, 2026 in 18m 29s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/JSValue.rs:680-684 |
big_int_from_decimal: from_js_host_call wrapper contract mismatch / dead is_empty() guard |
Annotations
Check warning on line 684 in src/jsc/JSValue.rs
claude / Claude Code Review
big_int_from_decimal: from_js_host_call wrapper contract mismatch / dead is_empty() guard
The `(!value.is_empty()).then_some(value)` guard on line 684 is dead code — `from_js_host_call` on line 680 already returns `Err` (and asserts `has_exception()` in debug/ASAN) whenever the FFI returns empty, so after the `?` `value` cannot be empty. Either drop the dead check, or if you want the FFI's documented empty-without-throw path handled here, wrap with `call_check_slow`/`from_js_host_call_generic` so the check is live.
Loading