Skip to content

Upgrade WebKit to 47f7250137c6 - #39371

Merged
Jarred-Sumner merged 4 commits into
mainfrom
farm/89e31e51/webkit-upgrade-47f7250137c6
Aug 18, 2026
Merged

Upgrade WebKit to 47f7250137c6#39371
Jarred-Sumner merged 4 commits into
mainfrom
farm/89e31e51/webkit-upgrade-47f7250137c6

Delete test/js/bun/jsc/webkit-upgrade-47f72501.test.ts

94c27b7
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 18, 2026 in 9m 30s

Code review found 1 important issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important scripts/build/deps/webkit.ts:6 WebKit upgrade test file deleted — behavioral changes ship without automated tests

Annotations

Check failure on line 6 in scripts/build/deps/webkit.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

WebKit upgrade test file deleted — behavioral changes ship without automated tests

Commit 94c27b75 deletes `test/js/bun/jsc/webkit-upgrade-47f72501.test.ts` — the file the PR description cites as this upgrade's automated coverage — leaving the net diff at 7 files with zero tests. REVIEW.md requires every behavioral change to ship an automated test in the same PR, and requires every test deletion to have a stated reason or replacement; neither is given here. Please restore the file (or state why it was removed and where the replacement coverage lives).