fix(bundler): don't overflow path buffer resolving long specifiers from in-memory files - #39256
Closed
robobun wants to merge 3 commits into
Closed
fix(bundler): don't overflow path buffer resolving long specifiers from in-memory files#39256robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 16, 2026 in 10m 43s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/bundler/bundler_files.test.ts:605-611 |
70000-byte URL doesn't exceed Windows path buffer (98302); Windows guards untested + inaccurate comment |
Annotations
Check warning on line 611 in test/bundler/bundler_files.test.ts
claude / Claude Code Review
70000-byte URL doesn't exceed Windows path buffer (98302); Windows guards untested + inaccurate comment
The comment "70000 bytes exceeds the path buffer on every platform" is inaccurate for Windows: `MAX_PATH_BYTES` there is `32767 * 3 + 1 = 98302` (src/bun_core/util.rs:698), not the ~64 KB the PR description states, so a 70019-byte specifier fits in the 98302-byte pooled buffer both before and after this fix. On Windows CI this test therefore passes with or without the change and none of the new `#[cfg(windows)]` length guards or the `join_abs_string_buf_checked` overflow branch are exercised — b
Loading