-
Notifications
You must be signed in to change notification settings - Fork 5k
shell(mkdir): accept --verbose instead of the misspelling --vebose #39221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
3
commits into
main
Choose a base branch
from
farm/4762795d/shell-mkdir-verbose-long-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−2
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import { $ } from "bun"; | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { tempDir } from "harness"; | ||
| import { readdirSync, statSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
|
|
||
| $.nothrow(); | ||
|
|
||
| async function mkdir(cwd: string, flags: string, operand: string) { | ||
| const words = flags.split(" ").filter(Boolean); | ||
| const { stdout, stderr, exitCode } = await $`mkdir ${words} ${operand}`.cwd(cwd).quiet(); | ||
| return { stdout: stdout.toString(), stderr: stderr.toString(), exitCode }; | ||
| } | ||
|
|
||
| describe.concurrent("bunshell mkdir", () => { | ||
| describe("verbose", () => { | ||
| // A verbose mkdir prints the path of every directory it creates, one per | ||
| // line. `--verbose` is the long spelling of `-v`; the parser used to | ||
| // accept only the misspelling `--vebose`. | ||
| test.each([ | ||
| ["-v", "dir", ["dir"]], | ||
| ["--verbose", "dir", ["dir"]], | ||
| ["-pv", "a/b", ["a", "a/b"]], | ||
| ["-p --verbose", "a/b", ["a", "a/b"]], | ||
| ["--parents --verbose", "a/b", ["a", "a/b"]], | ||
| ["--verbose --parents", "a/b", ["a", "a/b"]], | ||
| ["--verbose -p", "a/b", ["a", "a/b"]], | ||
| ])("mkdir %s %s prints %j", async (flags, operand, created) => { | ||
| using dir = tempDir("mkdir-verbose", {}); | ||
| const cwd = String(dir); | ||
|
|
||
| expect(await mkdir(cwd, flags, operand)).toEqual({ | ||
| stdout: created.map(name => `${join(cwd, name)}\n`).join(""), | ||
| stderr: "", | ||
| exitCode: 0, | ||
| }); | ||
| expect(statSync(join(cwd, operand)).isDirectory()).toBeTrue(); | ||
| }); | ||
|
|
||
| test.each(["--parents", "-p", ""])("mkdir %s a/b prints nothing without a verbose flag", async flags => { | ||
| using dir = tempDir("mkdir-quiet", { a: {} }); | ||
| const cwd = String(dir); | ||
|
|
||
| expect(await mkdir(cwd, flags, "a/b")).toEqual({ stdout: "", stderr: "", exitCode: 0 }); | ||
| expect(statSync(join(cwd, "a", "b")).isDirectory()).toBeTrue(); | ||
| }); | ||
|
|
||
| test.each(["--verbose --parents", "-pv"])( | ||
| "mkdir %s on an existing directory creates and prints nothing", | ||
| async flags => { | ||
| using dir = tempDir("mkdir-verbose-existing", { dir: {} }); | ||
| const cwd = String(dir); | ||
|
|
||
| expect(await mkdir(cwd, flags, "dir")).toEqual({ stdout: "", stderr: "", exitCode: 0 }); | ||
| expect(readdirSync(cwd)).toEqual(["dir"]); | ||
| }, | ||
| ); | ||
|
|
||
| test.each(["--verbose", "-v"])("mkdir %s on an existing directory fails and prints nothing", async flags => { | ||
| using dir = tempDir("mkdir-verbose-eexist", { dir: {} }); | ||
| const cwd = String(dir); | ||
|
|
||
| // Whether the message names the operand or the resolved path, and the | ||
| // macOS wording of EEXIST (bun_core's coreutils_error_map), are decided | ||
| // elsewhere; this only checks that verbose output stays off on failure. | ||
| expect(await mkdir(cwd, flags, "dir")).toEqual({ | ||
| stdout: "", | ||
| stderr: expect.stringMatching(/^mkdir: (?:.*[\\/])?dir: File (?:or folder )?exists\n$/), | ||
| exitCode: 1, | ||
| }); | ||
| }); | ||
|
|
||
| test("the misspelling --vebose is rejected like any other unknown option", async () => { | ||
| using dir = tempDir("mkdir-vebose", {}); | ||
| const cwd = String(dir); | ||
|
|
||
| expect(await mkdir(cwd, "--vebose", "dir")).toEqual({ | ||
| stdout: "", | ||
| stderr: expect.stringMatching(/^mkdir: illegal option -- /), | ||
| exitCode: 1, | ||
| }); | ||
| expect(readdirSync(cwd)).toEqual([]); | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.