Report a module's build errors to every later load of it (WebKit bump for oven-sh/WebKit#451) - #39204
Open
robobun wants to merge 6 commits into
Open
Report a module's build errors to every later load of it (WebKit bump for oven-sh/WebKit#451)#39204robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Aug 16, 2026 in 13m 13s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/js/bun/resolve/build-error.test.ts:99 |
Tests depend on WebKit fix (oven-sh/WebKit#451) that this PR does not pull in |
Annotations
Check failure on line 99 in test/js/bun/resolve/build-error.test.ts
claude / Claude Code Review
Tests depend on WebKit fix (oven-sh/WebKit#451) that this PR does not pull in
Commit f884bad7 removed the entire Bun-side fix, stating the replay is now fixed in oven-sh/WebKit#451 — but this PR does not bump `WEBKIT_VERSION` (still `f0f60fd2…`, identical to base), so the net diff is now this test file only. Per this PR's own verification on 114c35e (same WebKit pin), these tests "fail without the src/ changes"; the src/ changes are gone with nothing replacing them in this branch, so five of the six new tests will fail on CI. Either bump `WEBKIT_VERSION` to a commit conta
Loading