watcher: free the owned path of evicted watchlist entries - #39197
Merged
Claude / Claude Code Review
completed
Aug 16, 2026 in 15m 46s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/hot/watch-many-dirs.test.ts:193 |
New LSan leak test lacks explicit timeout |
Annotations
Check warning on line 193 in test/cli/hot/watch-many-dirs.test.ts
claude / Claude Code Review
New LSan leak test lacks explicit timeout
nit: this test has no per-test timeout, so it inherits the 5s default — but it spawns a debug-ASAN `bun --hot` with `BUN_DESTRUCT_VM_ON_EXIT=1` + `detect_leaks=1`, which `test/no-validate-leaksan.txt` already documents as pushing watch tests past 5s on its own. Both sibling `--hot` subprocess tests in this file set explicit 30000/60000 timeouts; consider adding a third argument (e.g. `}, 30000);`) to match. CI overrides the default via the runner's `--timeout` (with the ASAN multiplier), so this
Loading