bun test: report over-long coverage dir, JUnit outfile and bunfig root instead of panicking - #39104
Open
robobun wants to merge 1 commit into
Open
bun test: report over-long coverage dir, JUnit outfile and bunfig root instead of panicking#39104robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Aug 15, 2026 in 16m 31s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/test/coverage.test.ts:630-633 |
New tests set stdout: "pipe" but never drain it |
Annotations
Check warning on line 633 in test/cli/test/coverage.test.ts
claude / Claude Code Review
New tests set stdout: "pipe" but never drain it
These two tests explicitly set `stdout: "pipe"` but only await `[proc.stderr.text(), proc.exited]`, leaving stdout undrained — REVIEW.md's subprocess rule requires draining all pipes concurrently, and the sibling test added in `parallel.test.ts` in this PR does so. There's no actual deadlock risk here since `bun test` writes only the version banner to stdout, so this is just a hygiene/consistency nit: either add `proc.stdout.text()` to the `Promise.all` (matching `parallel.test.ts`) or drop the
Loading