bake: load files outside the bundle by their Windows path during prerendering - #39092
Closed
robobun wants to merge 4 commits into
Closed
bake: load files outside the bundle by their Windows path during prerendering#39092robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 14m 55s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/bake/dev/production.test.ts:629-636 |
Test pipes stdout but never drains it |
Annotations
Check warning on line 636 in test/bake/dev/production.test.ts
claude / Claude Code Review
Test pipes stdout but never drains it
The test sets `stdout: "pipe"` but only drains `stderr` and `exited` in the `Promise.all` — `proc.stdout` is never read. Per REVIEW.md ("Subprocess tests: drain pipes concurrently"), an unread pipe can fill the ~64KB OS buffer and deadlock the child; `bun build --app` does write to stdout (`prettyln!("done")` in production.rs). Add `proc.stdout.text()` to the `Promise.all` (and assert on the combined `{ stdout, stderr, exitCode }`), or drop `stdout: "pipe"` since the value is unused.
Loading