node:tls: inherit allowHalfOpen from the wrapped socket - #39066
Open
robobun wants to merge 4 commits into
Open
Claude / Claude Code Review
completed
Aug 15, 2026 in 14m 25s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/node/net.ts:270 |
kOnUpgradedClose instance field not initialized in Socket constructor |
Annotations
Check warning on line 270 in src/js/node/net.ts
claude / Claude Code Review
kOnUpgradedClose instance field not initialized in Socket constructor
The new `this[kOnUpgradedClose]` field is written here and read in `kCloseRawConnection` but never initialized in the Socket constructor, unlike the neighboring `this[kupgraded] = null` (net.ts:1597) and other symbol fields. REVIEW.md's built-in JS rules for `src/js/` require every instance field to be declared with a default in the class body for object-shape stability — consider adding `this[kOnUpgradedClose] = undefined;` next to the `kupgraded` init.
Loading