Skip to content

docs: corrections from re-verifying the fact-fix pass - #39013

Merged
alii merged 7 commits into
mainfrom
farm/955b1777/docs-fact-fixes-2
Aug 16, 2026
Merged

docs: corrections from re-verifying the fact-fix pass#39013
alii merged 7 commits into
mainfrom
farm/955b1777/docs-fact-fixes-2

docs: apply the statements-threshold note to bunfig.mdx too; match th…

db9de04
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 15, 2026 in 21m 45s

Code review found 4 potential issues

Found 4 candidates, confirmed 4. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 4
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit docs/runtime/c-compiler.mdx:65 isize alias added to c-compiler.mdx i64 row but not to sibling ffi.mdx table
🟡 Nit docs/bundler/plugins.mdx:237-238 onStart fix not applied to sibling docs/bundler/plugins.mdx

Annotations

Check warning on line 65 in docs/runtime/c-compiler.mdx

See this annotation in the file changed.

@claude claude / Claude Code Review

isize alias added to c-compiler.mdx i64 row but not to sibling ffi.mdx table

Adding `isize` to the i64 row here puts the two FFIType tables out of step: `docs/runtime/ffi.mdx:141` (also touched by this PR at line 344) still lists i64's aliases as just `int64_t`. `isize` is a valid i64 alias for `dlopen` too (`abi_type.rs:75`, `src/js/bun/ffi.ts:38`), and the u64 row already lists `usize` in both tables — consider adding `isize` at ffi.mdx:141 as well.

Check warning on line 238 in docs/bundler/plugins.mdx

See this annotation in the file changed.

@claude claude / Claude Code Review

onStart fix not applied to sibling docs/bundler/plugins.mdx

The `onStart` example fix (rewriting `import { plugin } from "bun"; plugin({...})` to `Bun.build({plugins: [...]})`) was applied to `docs/runtime/plugins.mdx` but not to the identical example at `docs/bundler/plugins.mdx:111-123`, even though this PR already touches that file (it fixed the env-plugin example there the same way). Consider giving the bundler page's `onStart` example the same `Bun.build({plugins: [...]})` treatment — same 'fix the whole class' pattern as the earlier `bunfig.mdx` st