install: keep linking the remaining bins when one bin or one dependency's bins fail to link - #38972
Open
robobun wants to merge 5 commits into
Open
install: keep linking the remaining bins when one bin or one dependency's bins fail to link#38972robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 10m 38s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/isolated-install.test.ts:403-410 |
Test pipes stdout but never drains it |
Annotations
Check warning on line 410 in test/cli/install/isolated-install.test.ts
claude / Claude Code Review
Test pipes stdout but never drains it
The test spawns `bun install` with `stdout: "pipe"` but never drains `proc.stdout` — only `proc.stderr.text()` and `proc.exited` are awaited. Per REVIEW.md's subprocess convention, either add `proc.stdout.text()` to the `Promise.all` or change to `stdout: "ignore"`; with 4 file: deps + 1 workspace it won't hit 64KB in practice, so this is a robustness nit rather than a live deadlock.
Loading