bun:test: format React 19 elements as JSX in snapshots and matcher diffs - #38934
Open
robobun wants to merge 4 commits into
Open
bun:test: format React 19 elements as JSX in snapshots and matcher diffs#38934robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 8m 30s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/test_runner/pretty_format.rs:495-497 |
Multi-line comment violates REVIEW.md one-line rule |
Annotations
Check warning on line 497 in src/runtime/test_runner/pretty_format.rs
claude / Claude Code Review
Multi-line comment violates REVIEW.md one-line rule
REVIEW.md's comment rule is "One line. … Prefer links to GitHub issues" — the original comment here was one line, this one spans three and narrates the React 19 rename (the comment-cop bot has already flagged it). The sibling check in `ConsoleObject.rs:2254` uses the local convention: `// For React 19 - https://github.com/oven-sh/bun/issues/17223`. Suggest keeping `// Is this a react element?` and putting the #17223 link on the `react.transitional.element` entry instead of the prose.
Loading