Skip to content

Remove dead code from node:http2, the HTTP/2 parser, JSC bindings, uSockets, and the builtin-name tables #38900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead code from node:http2, the HTTP/2 parser, JSC bindings, uSockets, and the builtin-name tables #38900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/bun-usockets/src/crypto/openssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,11 +2655,6 @@ void us_socket_sni_resolve(struct us_socket_t *s, struct ssl_ctx_st *ctx, int er
ssl_update_handshake(s);
}

void us_internal_ssl_handshake_abort(struct us_socket_t *s) {
s->ssl_fatal_error = 1;
ssl_close(s, 0, NULL);
}

/* ── Adopt-TLS (STARTTLS / Bun.connect upgrade) ──────────────────────────── */

/* Feed bytes that were already read off the wire (e.g. a ClientHello consumed
Expand Down Expand Up @@ -3068,10 +3063,6 @@ void *us_socket_server_name_userdata(struct us_socket_t *s) {
return SSL_CTX_get_ex_data(SSL_get_SSL_CTX(s_ssl(s)), us_sni_ex_idx);
}

void *us_internal_ssl_sni_userdata(struct us_socket_t *s) {
return us_socket_server_name_userdata(s);
}

const char *us_internal_ssl_sni_servername(struct us_socket_t *s) {
if (!s->ssl || !s_ssl(s)) return NULL;
return SSL_get_servername(s_ssl(s), TLSEXT_NAMETYPE_host_name);
Expand Down
9 changes: 0 additions & 9 deletions packages/bun-usockets/src/crypto/root_certs_darwin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ typedef struct OpaqueSecTrustRef* SecTrustRef;
typedef struct OpaqueSecPolicyRef* SecPolicyRef;
typedef int32_t OSStatus;
typedef uint32_t SecTrustSettingsDomain;
typedef uint32_t SecTrustSettingsResult;

// Security framework constants
enum {
Expand Down Expand Up @@ -564,12 +563,4 @@ extern "C" void us_load_system_certificates_macos(STACK_OF(X509) **system_certs)
security->CFRelease(certificates);
}

// Cleanup function for Security framework
extern "C" void us_cleanup_security_framework() {
SecurityFramework* framework = g_security_framework.exchange(nullptr);
if (framework) {
delete framework;
}
}

#endif // __APPLE__
5 changes: 0 additions & 5 deletions packages/bun-usockets/src/crypto/root_certs_platform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,4 @@ void us_load_system_certificates_linux(STACK_OF(X509) **system_certs);
void us_load_system_certificates_macos(STACK_OF(X509) **system_certs);
void us_load_system_certificates_windows(STACK_OF(X509) **system_certs);

// Platform-specific cleanup functions
#ifdef __APPLE__
void us_cleanup_security_framework();
#endif

}
2 changes: 0 additions & 2 deletions packages/bun-usockets/src/internal/internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,7 @@ int us_internal_ssl_write(us_socket_r s, const char *data, int length);
unsigned int us_internal_ssl_spill_pending(us_socket_r s);
void *us_internal_ssl_get_native_handle(us_socket_r s);
struct us_bun_verify_error_t us_internal_ssl_verify_error(us_socket_r s);
void *us_internal_ssl_sni_userdata(us_socket_r s);
const char *us_internal_ssl_sni_servername(us_socket_r s);
void us_internal_ssl_handshake_abort(us_socket_r s);
/* SSL_CTX_free(ls->ssl_ctx) + sni_free(ls->sni). Called from us_listen_socket_close. */
void us_internal_listen_socket_ssl_free(struct us_listen_socket_t *ls);
/* Opaque SSL_CTX_up_ref/SSL_CTX_free so context.c needn't include OpenSSL. */
Expand Down
303 changes: 0 additions & 303 deletions scripts/find-dead-exports.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/ast/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,11 +1630,6 @@ impl Data {
None
}
}
/// True if this is an `EString`.
#[inline]
pub fn is_e_string(&self) -> bool {
matches!(self, Data::EString(_))
}

// ── Remaining StoreRef<E::*> field-style accessors ──────────────────
// Callers `.unwrap()` (or pattern-match) — the `Option` is the cheapest
Expand Down
Loading
Loading