install: bound isolated store entry names; tarball URL credentials; file: tarballs relative to their folder package - #38867
Merged
Claude / Claude Code Review
completed
Aug 15, 2026 in 24m 31s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/isolated-install.test.ts:2340 |
Git test install step does not isolate bun's internal git spawn from system/global config |
Annotations
Check warning on line 2340 in test/cli/install/isolated-install.test.ts
claude / Claude Code Review
Git test install step does not isolate bun's internal git spawn from system/global config
nit: this test builds `gitEnv` with `GIT_CONFIG_NOSYSTEM`/`GIT_CONFIG_GLOBAL` for its direct git calls but passes plain `bunEnv` to `runBunInstall`, so bun's internal git clone reads the CI machine's system/global config. The sibling git test in this file (line ~970) and `bun-install-git-deps.test.ts` both spread the git-isolation vars into the install env — since `gitEnv` is already defined here, consider `runBunInstall(gitEnv, packageDir)` for consistency.
Loading