install: send credentials embedded in --registry and registry env var URLs - #38796
Merged
Claude / Claude Code Review
completed
Aug 15, 2026 in 15m 38s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/options_types/schema.rs:181-183 |
has_credentials() duplicates existing helper in src/ini/lib.rs |
Annotations
Check warning on line 183 in src/options_types/schema.rs
claude / Claude Code Review
has_credentials() duplicates existing helper in src/ini/lib.rs
The new `NpmRegistry::has_credentials()` duplicates the private free function `has_credentials(registry: &NpmRegistry)` at `src/ini/lib.rs:1306-1308`. Since `bun_ini` already imports `NpmRegistry` via `bun_api`, delete the local free function and rewrite its two call sites in `apply_registry_auth` (lines 1315 and 1330) to `registry.has_credentials()` so the two copies don't drift.
Loading