install: fix default-trusted lifecycle scripts being blocked after yarn.lock migration - #38795
Open
robobun wants to merge 7 commits into
Open
install: fix default-trusted lifecycle scripts being blocked after yarn.lock migration#38795robobun wants to merge 7 commits into
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 11m 45s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/yarn.rs:1056-1059 |
Stale comment: 'codeload tarballs' rationale now attached to wrong block |
Annotations
Check warning on line 1059 in src/install/yarn.rs
claude / Claude Code Review
Stale comment: 'codeload tarballs' rationale now attached to wrong block
This comment used to sit directly above the `Entry::is_remote_tarball(resolved) || resolved.ends_with(b".tgz")` fallback it justifies — the PR moved that fallback down into the `!result.valid` branch (line 1069) but left the comment attached to the new `if is_direct_url_dep` check, whose condition none of the cited examples (workspace deps, `file:`, codeload tarballs) reach. Move it down to the `.tgz` fallback it still describes, or drop it.
Loading